[BUG] Divide by zero in camera fader

This topic has 0 replies, 2 voices, and was last updated 4 years, 11 months ago by Gavalakis.

Viewing 3 posts - 1 through 3 (of 3 total)

April 27, 2021 at 1:15 am #15986

locutis

Participant

I think camerafader needs an edge case for when time is zero. see attached. thanks!

IEnumerator CoroutineFadeIn(float time) {

alpha = 1;

if (time <= 0) alpha = 0; // fixing divide by zero

else while ( alpha > 0 ) { yield return null; alpha -= ( 1 / time ) * Time.deltaTime; }

}

IEnumerator CoroutineFadeOut(float time) {

alpha = 0;

if (time <= 0) alpha = 1; // fixing divide be zero

else while ( alpha < 1 ) { yield return null; alpha += ( 1 / time ) * Time.deltaTime; }

}

May 5, 2021 at 12:08 am #15988

Gavalakis

Keymaster

Hey,

Yep, that is a good fix. I didn’t expect people would use 0 time 🙂

Thanks!

May 7, 2021 at 11:49 pm #15987

locutis

Participant

😀

Viewing 3 posts - 1 through 3 (of 3 total)