onFinish callback on graphs

This topic has 0 replies, 2 voices, and was last updated 7 years, 8 months ago by w.

Viewing 7 posts - 1 through 7 (of 7 total)

Author

Posts

August 23, 2018 at 4:26 am #17193

Participant

The onFinish callback in Graph.cs is invoked regardless of whether the GraphOwner completes playing or is stopped by calling StopBehaviour().
this causes trouble as we use onFinish callback to trigger loading the next level and I don’t want the load to happen if it’s stopped explicitly.

///Stop the current running graph

public void StopBehaviour(){

if (graph != null){

graph.Stop(); // <---- THIS DOES NOT PASS success STATE TO Graph.Stop, CAUSING onFinish(success) TO ALWAYS HAPPEN.

if (onOwnerBehaviourStateChange != null){

onOwnerBehaviourStateChange(this);

}

///Stops the graph completely and resets all nodes.

public void Stop(bool success = true){

if (!isRunning && !isPaused){

return;

}

runningGraphs.Remove(this);

MonoManager.current.onUpdate -= UpdateGraph;

isRunning = false;

isPaused = false;

for (var i = 0; i < allNodes.Count; i++){

allNodes[i].Reset(false);

allNodes[i].OnGraphStoped();

}

OnGraphStoped();

if (onFinish != null){

onFinish(success);

onFinish = null;

}

So i was wondering if it make sense to add a success parameter to StopBehaviour() so that onFinish doesn’t always trigger with success=true.

August 23, 2018 at 4:34 am #17199

Participant

an alternative solution would be providing a function to clear up onFinish actions so that we can do something like

1 2	owner.graph.ClearOnFinishActions(); owner.graph.stop(false);

August 23, 2018 at 2:56 pm #17198

Gavalakis

Keymaster

Hello,

Hmm… I think that adding an optional bool parameter for StopBehaviour like in your first suggestion, makes total sense and I can definitely add this in the next version officially:

///Stop the current running graph

public void StopBehaviour(bool success = true){

if (graph != null){

graph.Stop(success);

if (onOwnerBehaviourStateChange != null){

onOwnerBehaviourStateChange(this);

}

Would that work for you?
I could of course also add your second suggestion ClearOnFinishActions() if required 🙂

Let me know.
Thank you!

August 23, 2018 at 9:22 pm #17197

Participant

Hey Gavalakis, thanks for your response. Adding an optional boolean definitely works. It’d be awesome if you could add clearOnFinishActions too, if that doesn’t go against your design.

Are you planning on releasing the new version any time soon? 🙂

August 25, 2018 at 11:06 am #17196

Gavalakis

Keymaster

Hello again,

The new version has just gone live recently!
It does include your first suggestion (optional boolean parameter), but didn’t manage to squeeze in the ClearOnFinishActrions since I did send the new version before I had the chance to check on your new reply above 🙂

August 25, 2018 at 11:38 am #17195

Participant

Congratulations on the new version! Thanks for making the changes so quickly!

August 30, 2018 at 11:33 pm #17194

Gavalakis

Keymaster

Thank you! You are very welcome 🙂

Author

Posts

Viewing 7 posts - 1 through 7 (of 7 total)

You must be logged in to reply to this topic.