Reply To: Dynamic selectors/sequencers do not reset re-evaluated connections

Forums 💬 NodeCanvas 🗨️ General Discussion Dynamic selectors/sequencers do not reset re-evaluated connections Reply To: Dynamic selectors/sequencers do not reset re-evaluated connections

#13572
timv
Participant

    Hi Gavalakis,

    Sorry for not getting back to you sooner. I had quite a busy week. I thought about this some more, but I do think the code also needs to be there in case of success. See the attached two images. When I wrote this I forgot about how NC uses the Status to show the colors of the connections. So, even though in theory it could work, (as long as the parent node issues a recursive Reset eventually,) I don’t think removing the code from the Success case is the right thing to do. The image without_reset_other_on_success.png really looks incorrect.

    On a related node (sorry for the pun), I noticed today that the step sequencer never resets its child nodes. I was also a bit surprised to find out that it increases the index even when the connection returned status Running. I’m now thinking if there is a way to add some asserts that check for missing Resets. Or if we could establish the exact rules and then go over all composite nodes to double check them.

    Tim