[Bug] BinarySelector and Breakpoint

[psykawParticipant]

I think there is a bug with BinarySelector and breakpoint.
If I set a breakpoint on a BinarySelector which is not dynamic, it’s always the true connection which is executed (cf screesnhots).

The breakpoint puts node status at Running and the BinarySelector check if status == Resting to check conditions.
Why breapoint puts node status at Running ?

Thanks.

[GavalakisKeymaster]

Thanks for the report.
It’s actually a bug in the way I handled breakpoints when Unity Editor is also paused and not a problem with Binary per-se.
Here is the fix:
1) Node.Execute, right after the log:

1 2 3 4 5 6 7 8 9 10 11

ParadoxNotion.Services.Logger.LogWarning(string.Format("Node: '{0}' | ID: '{1}' | Graph Type: '{2}' | Context Object: '{3}'", name, ID, graph.GetType().Name, contextName), "Breakpoint", this); if (owner != null){ owner.PauseBehaviour(); } if (breakEditor){ StartCoroutine( YieldBreak(()=> { if (owner != null){ owner.StartBehaviour(); } })); } status = Status.Running; return Status.Running;

2) Change the YieldBreak coroutine to this:

1 2 3 4 5 6 7 8

///Helper for breakpoints IEnumerator YieldBreak(System.Action resume){ Debug.Break(); yield return null; resume(); }

Breakpoints puts node to Status.Running to fake mid code execution and since the breakpoint is handled before the node is actually executed.

Thank you.

[psykawParticipant]

Hey,

The fix doesn’t solve the issue. Binary Selector execute true connection even if condition return false.

[GavalakisKeymaster]

Oh. I’ve mised the part where you said “when it’s not dynamic”.
So, I took another look at this. Probably the best “global” fix is to use a flag that a breakpoint is reached and reset the flag (as well as the status of the node back to Resting after resuming. Here is the current code changes which I’ve tested and work fine so far:

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21

#if UNITY_EDITOR if (isBreakpoint){ if (status == Status.Resting){ var breakEditor = NodeCanvas.Editor.Prefs.breakpointPauseEditor; var owner = agent as GraphOwner; var contextName = owner != null? owner.gameObject.name : graph.name; ParadoxNotion.Services.Logger.LogWarning(string.Format("Node: '{0}' | ID: '{1}' | Graph Type: '{2}' | Context Object: '{3}'", name, ID, graph.GetType().Name, contextName), "Breakpoint", this); if (owner != null){ owner.PauseBehaviour(); } if (breakEditor){ StartCoroutine( YieldBreak(()=> { if (owner != null){ owner.StartBehaviour(); } })); } breakPointReached = true; status = Status.Running; return Status.Running; } if (breakPointReached){ breakPointReached = false; status = Status.Resting; } } #endif

You will of course need to add a private bool breakPointReached; to the class as well.

Thanks.

[Author]

Posts