[BUG MAYBE?] Latch in ActionTask

[wParticipant]

Hello!

In function EndAction() in ActionTask.cs :

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16

public void EndAction(bool? success){       /// Notice that the "latch" variable is set BEFORE the status check.     /// If EndAction(true/false) is called BEFORE the actionTask starts, latch will be set to true.       latch = success != null ? true : false;       if (status != Status.Running){ return; }       isPaused = false; //status = success == true? Status.Success : Status.Failure; status = success == null? Status.Resting : (success == true? Status.Success : Status.Failure); OnStop(success == null); }

and in the ExecuteAction function:

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42

///Ticks the action for the provided agent and blackboard public Status ExecuteAction(Component agent, IBlackboard blackboard){      if (!isActive) {         return Status.Failure; }   if (isPaused){ //then resume startedTime += Time.time - pausedTime; isPaused = false; }   if (status == Status.Running){ OnUpdate(); latch = false;         return status; }           /// NOTICE HERE IF LATCH IS SET TO TRUE, ACTIONTASK WILL SKIP THE CURRENTFRAME. SO IF ENDACTION() IS CALLED BEFORE         /// THE ACTION STARTS, THE ACTION WON'T RUN, WHICH IS PROBLEMATIC IN OUR CASE. IS THIS BY DESIGN? PERSONALLY I'D PREFER         /// EndAction TO DO NOTHING IF IT'S CALLED BEFORE THE ACTION RUNS.   if (latch){ //to be possible to call EndAction anywhere latch = false;         return status; }   if (!Set(agent, blackboard)){         return Status.Failure; }   startedTime = Time.time; status = Status.Running; OnExecute(); if (status == Status.Running){ OnUpdate(); } latch = false; return status; }

[GavalakisKeymaster]

Hello,

Thanks for the elaboration on the code. I don’t foresee any problems by moving the “latch” variable set AFTER the status != Status.Running check as you propose. I will need to re-check everything to make sure though. Out of curioucity, how can it be (or why) are you calling EndAction before the action is running by the way? Are you doing something custom with the graphs?

Thanks 🙂

[wParticipant]

Hi Gavalakis,

Thanks for your response. In my game I have a custom action task that plays a playableDirector, and the task ends when the director finishes. playableDirector has an OnDirectorStop callback, from which EndAction() of the task is triggered. However in Unity, OnDirectorStop is always triggered before the director starts playing, causing EndAction happens before start.

[GavalakisKeymaster]

Hello again,
Thanks for the follow up and the details. I’ve moved latch to be set after the Status.Running check for the next version 🙂

[wParticipant]

Thank you!

[Author]

Posts