FlowInput.isConnected is always false when play on device

[toto007Participant]

I need known to runtime when an flowInput is connected to a node. So I use the variable Port.isConnected. It’s works play editor but when I play on my device android it’s always false:

1 2 3 4 5 6 7 8 9 10 11

FlowInput outCondition = AddFlowInput ("Out Condition", (f) => {                  //to do something             })   FlowInput AddFlowInput ("In", (f) => {                  if(outCondition.isConnected==true) //Even if the flowinput is connected this returns false when I am in play mode on the device                        //to do something                 });             });

So I tried to call GetFirstInputConnection() instead of IsConnected and it works in version build runtime and version editor runtime

1 2 3

outCondition.GetFirstInputConnection () !=null

Although I found the workaround I was wondering if I was proceeding towards the right way.

[GavalakisKeymaster]

Hello again,

Sorry for the late reply.
Port.isConnected currently only works in editor. This is done so for performance reasons since Port.isConnected is set correctly within a part of the code that is a bit performance heavy and not really needed in runtime.
With that said, I will make isConnected work correctly in runtime as well for consistency in the next version.
Using GetFirstInputConnection() != null is definetely a solution to that which I might just use as well 🙂

Thanks!

[madaboutpandasParticipant]

We also stumbled upon this issue during development. We would very much appreciate to have this feature available at runtime.

[GavalakisKeymaster]

Thank you for your input and confirmation that this is needed.

I have added this to the roadmap. It’s a bit harder to implement than I thought perfomance wise, cinsidering the current implementation, but it will happen 🙂

Thank you.

[toto007Participant]

[quote quote=2265]Thank you for your input and confirmation that this is needed. I have added this to the roadmap. It’s a bit harder to implement than I thought perfomance wise, cinsidering the current implementation, but it will happen  Thank you. [/quote]

I would not like to ask a question with a too complex answer but I would like to know the reasons why it could lead to a deterioration in performance.

I ask this question because I’m modifying your framework quite intensively for my use case and I wouldn’t want it to make any mistakes that I shouldn’t be making

[GavalakisKeymaster]

Hey,

It’s just that the way isConnected is determined in the editor, is after calling the FlowNode.GatherPorts -> ValidateConnections.
ValidateConnections is currently wrapped in a #if UNITY_EDITOR, because the way validations are made a performance costly (lots of foreach iterations and type conversion checks), which are otherwise not really required in runtime. Unfortunately or not, isConnected is set from within this Validation method.

So, if we were to simply remove #if UNITY_EDITOR and run ValidateConnections method, while isConnected will work correctly, there will be a performance cost.

Thus, the solution would be to find another way to determine isConnected and move it outside of the Validate methods, which requires some refactoring to make sure everything works as intended.

🙂

[Author]

Posts