[Major Bug] Using nested dialogue trees causes Unity editor to freeze

[cherrysockParticipant]

So, I just found out, that if you put a nested dialogue tree as the last node in another dialogue tree, the Unity editor just freezes when the tree finishes. I had to use task manager to stop it.

[attachment file=”Buggy tree.JPG”]

But if there is at least one more node after the nested tree, it works without issues:

[attachment file=”Good tree.JPG”]

Here is a sample project: [DELETED LINK]

Unity version: 2019.3.7f1

NodeCanvas: 3.0.3f1

[GavalakisKeymaster]

Hello,
Thank you for the bug report. I can confirm and currently looking at this. I will update you here once I have a fix.
(PS: Please don’t post links that include the whole NodeCanvas package).

Thanks.

[cherrysockParticipant]

Any news?

It’s getting really annoying to deal with this issue.

[GavalakisKeymaster]

Hello there,

Yes, this is fixed (sorry for no updating the thread). To fix this, please up up Graph.cs and change lines # 612 – 620:

From this:

1 2 3 4 5 6 7 8 9 10 11

if ( onFinish != null ) {                 onFinish(success);                 onFinish = null;             }               isRunning = false;             isPaused = false;               elapsedTime = 0;

To this:

1 2 3 4 5 6 7 8 9 10 11

isRunning = false;             isPaused = false;               if ( onFinish != null ) {                 onFinish(success);                 onFinish = null;             }               elapsedTime = 0;

The change is basically moving the isRunning and isPaused sets before the onFinish callback is called.

Please let me know if that works for you.
Thank you.

[cherrysockParticipant]

Yeah, it works now. Thanks.

[GavalakisKeymaster]

Great. Thanks for letting me know 🙂

[Author]

Posts