[NodeCanvas] Support for DIctionary

[leanon00Participant]

Hello again! Made dictionaries with SO as key viable (if they were not..)

Why? Because scriptable object as keys for dictionaries are better that strings (more flexible, less typos errors etc)

EditorUtils.GUIEditors.cs (lines: 223 – 253)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35

if ( GUILayout.Button("Add Element") ) {                 if (!typeof(UnityObject).IsAssignableFrom(keyType))                 {                     object newKey = null;                     if (keyType == typeof(string))                     {                         newKey = string.Empty;                     }                     else                     {                         newKey = Activator.CreateInstance(keyType);                     }                       if (dict.Contains(newKey))                     {                         Logger.LogWarning(string.Format("Key '{0}' already exists in Dictionary", newKey.ToString()), "Editor");                         return dict;                     }                       keys.Add(newKey);                 }                 //CustomPatch: Added support for dictionary SO keys.                 else if (typeof(ScriptableObject).IsAssignableFrom(keyType))                 {                     keys.Add(ScriptableObject.CreateInstance(keyType));                 }                 else                 {                     Logger.LogWarning("Can't add a 'null' Dictionary Key", "Editor");                     return dict;                 }                   values.Add(valueType.IsValueType ? Activator.CreateInstance(valueType) : null);             }

[GavalakisKeymaster]

Hello again!

I will have to double check if everything works correctly before adding this because by convention dictionaries are only supported with string for KEY in various places in code (both serialization and other reflection utilities wise).

Thanks! 🙂

[Author]

Posts