NodeCanvas With Incremental Compiler: assembly definition files?

[alicParticipant]

Hey,
I just tried to get node canvas working with a project using the incremental compiler (it’s pretty awesome!), and had to do a tiny bit of work getting node canvas to work with an assembly definition file. I noticed that node canvas uses a general strategy of using #if UNITY_EDITOR around its editor classes instead of, or in addition to putting all of them in separate editor folders.

This approach actually worked great for setting things up, but there were a few editor classes not using this approach. Once I added the directive to these files node canvas compiled perfectly all in one assembly definition file, and allowed me to build as well. The files are:

DialogueTreeControllerInspector
GraphEditor_Events
GraphEditor_Panels
GraphEditor_Toolbar

Anyway, was just wondering if you would be willing to add the unity editor directive to these files as well, so NodeCanvas can work with assembly definition files out of the box, unless there is some reason these files must be excluded.

Thanks a lot for your time,

Alic

[GavalakisKeymaster]

Hello Alic,

There was no aparent reason why these files were not wrapped in an #if UNITY_EDITOR (I just missed them :).
In the latest version of NodeCanvas gone live yesterday, these files are correctly wrapped in UNITY_EDITOR define symbol. There is also a big folder restructure as well by the way, thus I suggest to please make a clean installation when you decide to update.

Thanks!

[alicParticipant]

Great, thanks Gavalakis!

[Author]

Posts