Pull Request! I've added features to NC!

Forums 💬 NodeCanvas 🗨️ General Discussion Pull Request! I've added features to NC!

Viewing 3 posts - 1 through 3 (of 3 total)
  • Author
    Posts
  • #14030
    hatchling
    Participant

      Hey there.

      While using NC I’ve added features and other minor improvements that I think others may find useful. I’d like them to be supported in future updates if possible.
      Do you have a git repository that I may create a branch for? Then we may discuss the changes and consider pulling them into the master branch.

      Changes include:
      Support for using Enums (of any type) instead of Strings for identifiers and tags. Includes multiple ways of searching for states from code, UI integration, 0 GC Allocation (except in initialization cases). Enums (in my opinion) are superior to strings for scripting because of their deeper integration with the programming language: They are easier to refactor and typos are caught as compiler errors, whereas with strings you need to search the project for occurances of strings and typos will silently fail.
      – Supplied the option to update graphs manually via another script as opposed to being updated via MonoManager. (This is required in cases where execution order is important and can only be resolved via execution by another script.)
      – Supplied the option to execute nested FSMs immediately upon OnEnter, instead of deferring execution to the next frame. (This is required in some cases, because the condition which triggered the state change may need to be evaluated by again nested FSMs, and the condition may change between frames, leading to bugs.)
      – Various GC allocation improvements.
      – Null handling improvements.

      I wish to keep upgrading NodeCanvas as updates are made (mainly due to performance concerns at instantiation, which I presume may be fixed in a future update), and if possible I’d like our changes to be integrated so that upgrading is smooth.

      Attached is a screenshot showing an example of the Enum integration into the UI. I’ve chosen arbitrary enums (some belonging to other assets).

      #14032
      Gavalakis
      Keymaster

        Hello and happy new year!

        That sounds good. Thanks a lot 🙂
        I am certainly interested in seeing the changes you made!
        There is no git repository (I use bitbucket), but if you send me your modified NC package (support_AT_paradoxnotion.com) I will be able to diff it and get the changes you’ve made.
        Also feel free to add me in skype if you want as well (nuverian – gavalakis vaggelis) if you want to discuss the changes.

        Thank you 🙂

        #14031
        hatchling
        Participant

          I’ve added two accounts named “Vaggelis Gavalakis” to skype. Hopefully at least one of them is you. 😛

        Viewing 3 posts - 1 through 3 (of 3 total)
        • You must be logged in to reply to this topic.