Small tweak — Better list reordering (inserting vs swapping)

[birdinthecityParticipant]

Small “fix” to improve the reorderable list functionality (such as Variable list).

Currently, variable lists are reordered by swapping positions. So if you’re trying to drag a variable from bottom of list to top, the previous top item moves to the bottom. This doesn’t make sense.

Instead, the item you’re moving should be inserted into the list at a given position. No swapping necessary. This change makes maintaining an orderly list much more straightforward.

This is a very small fix in EditorUtils_ReorderableList.cs lines 134-143:
Relevant code change: 138-139.

1 2 3 4 5 6 7 8 9 10 11

if (e.type == EventType.MouseUp){ if (unityObject != null){ Undo.RecordObject(unityObject, "Reorder Item"); } var pickObj = list[pickedIndex]; list.Remove(pickObj); list.Insert(i, pickObj); pickedListIndex[list] = -1; GUI.changed = true; if (unityObject != null){ EditorUtility.SetDirty(unityObject); } }

[GavalakisKeymaster]

Hey,

Indeed that is something that slipped by and the Reorderable List has already been fixed for the next hotfix version, pretty much exactly in the way you posted here 🙂

Thank you!

[bcristianParticipant]

I was just about to post about this issue when I thought to search first.
I’ve made the following change, which does the same thing but faster:

1 2 3 4 5

var pickObj = list[pickedIndex];                         var step = i < pickedIndex ? -1 : 1;                         for (var j = pickedIndex; j != i; j += step)                             list[j] = list[j + step];                         list[i] = pickObj;

[Author]

Posts