TaskTools.cs Compare bug

[royParticipant]

I’ve found a bug. I had a condition in a conditionlist which was comparing a global blackboard int to a static int. The test was always returning false though. I tracked it down to the following code in TaskTools.cs.

Before:

1 2 3 4 5 6 7 8 9 10

public static bool Compare(IComparable a, IComparable b, CompareMethod cm, float floatingPoint = 0.05f){   if (cm == CompareMethod.EqualTo){ if (a.GetType() == typeof(float)) return Mathf.Abs((float)a - (float)b) <= floatingPoint;                       return a == b;                   //always returning false }

I modified the code to this which fixed the problem

1 2 3 4 5 6 7 8 9 10 11 12 13

public static bool Compare(IComparable a, IComparable b, CompareMethod cm, float floatingPoint = 0.05f){   if (cm == CompareMethod.EqualTo){ if (a.GetType() == typeof(float)) return Mathf.Abs((float)a - (float)b) <= floatingPoint;                   if (a.GetType() == typeof(int))                     return (int)a == (int)b;                   return a.CompareTo(b) == 0; }

[royParticipant]

Oops – messed up the formatting there sorry – hopefully you can still follow my point.

[GavalakisKeymaster]

Hey,
Yep there is a bug. It’s been fixed in the new submitted version 1.5.8 soon to go live 🙂

Here is a shorter fix:

1 2 3 4 5 6 7

if (cm == CompareMethod.EqualTo){ if (a.GetType() == typeof(float)) return Mathf.Abs((float)a - (float)b) <= floatingPoint; return a.CompareTo(b) == 0; }

Cheers

[Author]

Posts