ValidateList() bug?

[adbourdagesParticipant]

Taken from ActionList.cs, the following method seems a little off:

1 2 3 4 5 6 7 8

void ValidateList(){ for (var i = 0; i < actions.Count; i++){ if (actions[i] == null){ actions.RemoveAt(i); } } }

It should have a i-- right after actions.RemoveAt(i) otherwise it skips an element.

initial actions = [null,null,value1]

i = 0; action is removed at 0 => actions [null,value1]
i = 1; action at 1 is not null
loop completed

resulting actions = [null,value1]

Besides i-- it is also possible to count the loop backwards and avoid messing with the iterator.

[GavalakisKeymaster]

Hello,

Thanks for your report. I will fix that.
By the way, it’s totaly unlikely that you will end up with a null action task in the list, since missing tasks (and nodes) are replaced automaticaly with a MissingTask/MissingNode type.
Did you somewhow managed to end up with a null action task in the list?
If so I will be glad to know how, since it might be a bug there.

Thanks!

[adbourdagesParticipant]

Hi,

No, that didn’t happen. I just noticed the function and the Remove() caught my eye.

Thanks for listening & fixing 🙂

[Author]

Posts